Go: Support more dependency managers in IsGolangVendorDirectory#18929
Merged
Go: Support more dependency managers in IsGolangVendorDirectory#18929
IsGolangVendorDirectory#18929Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This pull request enhances the IsGolangVendorDirectory function to support additional dependency managers by checking for extra files.
- Added support for Gopkg.lock and vendor.conf detection
- Maintained existing checks for modules.txt and glide.yaml
Reviewed Changes
| File | Description |
|---|---|
| go/extractor/util/util.go | Updated IsGolangVendorDirectory to support additional dependency managers |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
owen-mc
reviewed
Mar 6, 2025
Contributor
owen-mc
left a comment
owen-mc
left a comment
There was a problem hiding this comment.
Content is good. Retarget to rc/3.17 so it gets into the next release.
mbg
force-pushed
the
mbg/go/filter-more-vendor-dirs
branch
from
c47bad2 to
b872c60
Compare
owen-mc
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.