Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test for SyntheticGlobal functionality in Ruby dataflow summaries.
- Adds a new test class in summaries.rb to exercise tainted flows from database operations.
- Updates Summaries.ext.yml to map the newly introduced methods to SyntheticGlobal.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ruby/ql/test/library-tests/dataflow/summaries/summaries.rb | Introduces SynthGlobalTest with store and read methods for testing tainted flow handling. |
| ruby/ql/test/library-tests/dataflow/summaries/Summaries.ext.yml | Adds method mappings for saveToDatabase and readFromDatabase using SyntheticGlobal. |
Comments suppressed due to low confidence (1)
ruby/ql/test/library-tests/dataflow/summaries/summaries.rb:170
- The class name 'SynthGlobalTest' is inconsistent with the 'SyntheticGlobal' reference used in the YAML file. Rename it to 'SyntheticGlobalTest'.
class SynthGlobalTest
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
aibaars
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.