Skip to content

Rust: fix crate_graph.rs#19084

Merged
redsun82 merged 1 commit intoredsun82/rust-analyzer-updatefrom
aibaars/rust-analyzer-update
Mar 21, 2025
Merged

Rust: fix crate_graph.rs#19084
redsun82 merged 1 commit intoredsun82/rust-analyzer-updatefrom
aibaars/rust-analyzer-update

Conversation

@aibaars
Copy link
Contributor

@aibaars aibaars commented Mar 20, 2025

No description provided.

Copilot AI review requested due to automatic review settings March 20, 2025 18:09
@github-actions github-actions bot added the Rust Pull requests that update Rust code label Mar 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the crate graph extraction logic by removing the direct dependency on the old CrateGraph type and using updated database interfaces instead.

  • Replace usage of "CrateGraph" with methods on "db" and updated iteration over crates.
  • Update function signatures and invocations to remove the extra "crate_graph" parameter.
  • Adjust helper functions (e.g. make_path, emit_visibility) accordingly.
Comments suppressed due to low confidence (1)

rust/extractor/src/crate_graph.rs:62

  • [nitpick] The variable 'krate_id' now appears to represent a Crate instance rather than an identifier; consider renaming it (e.g., to 'krate') to reflect its meaning more clearly.
crate_id_map.insert(*krate_id, (root_module_file, hash));

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@redsun82 redsun82 merged commit fd84b67 into redsun82/rust-analyzer-update Mar 21, 2025
5 of 6 checks passed
@redsun82 redsun82 deleted the aibaars/rust-analyzer-update branch March 21, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants