Ruby: Make getPreUpdateNode Unique Again
#19121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- ruby/ql/consistency-queries/DataFlowConsistency.ql: Language not supported
- ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPrivate.qll: Language not supported
- ruby/ql/test/library-tests/dataflow/global/Flow.expected: Language not supported
- ruby/ql/test/library-tests/dataflow/local/DataflowStep.expected: Language not supported
- ruby/ql/test/library-tests/dataflow/local/TaintStep.expected: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
hvitved
force-pushed
the
ruby/pre-update-unique
branch
from
e7c59c3 to
15bfeab
Compare
aschackmull
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this PR for Rust, we revert the change introduced in #10444, where
getPreUpdateNodewas made non-unique, and instead use reverse post-update steps to ensure that side-effects propagate correctly in the case of compound arguments.