Rust: Reduce CI noise from the SummaryStats query #19180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
added
no-change-note-required
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (11)
- rust/ql/integration-tests/hello-project/summary.expected: Language not supported
- rust/ql/integration-tests/hello-project/summary.qlref: Language not supported
- rust/ql/integration-tests/hello-workspace/summary.cargo.expected: Language not supported
- rust/ql/integration-tests/hello-workspace/summary.qlref: Language not supported
- rust/ql/integration-tests/hello-workspace/summary.rust-project.expected: Language not supported
- rust/ql/src/queries/summary/Stats.qll: Language not supported
- rust/ql/src/queries/summary/SummaryStats.ql: Language not supported
- rust/ql/src/queries/summary/SummaryStatsLess.ql: Language not supported
- rust/ql/test/query-tests/diagnostics/SummaryStats.qlref: Language not supported
- rust/ql/test/query-tests/diagnostics/SummaryStatsLess.expected: Language not supported
- rust/ql/test/query-tests/diagnostics/SummaryStatsLess.qlref: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
reviewed
Apr 2, 2025
| * @description A table of summary statistics about a database, with data that | ||
| * has been found to be noisy on tests removed. | ||
| * @kind metric | ||
| * @id rust/summary/summary-statistics-less |
There was a problem hiding this comment.
SummeryStatsReduced.ql and ust/summary/summary-statistics-reduced instead?
There was a problem hiding this comment.
Yes I think I like that a bit more. Updated.
hvitved
previously approved these changes
Apr 2, 2025
rust/ql/test/query-tests/diagnostics/SummaryStatsReduced.qlref
Dismissed
Show dismissed
Hide dismissed
hvitved
approved these changes
Apr 4, 2025
|
Finally fixed all the problems with this (including working around an issue with the DCA run). Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce CI noise from the SummaryStats query:
SummaryStats.qlinto predicates inStats.qll.SummaryStatsLess.qlthat is a cut down version - it doesn't include the frequently fluctuating element and taint stats.This should greatly reduce the amount of effort we spend chasing up benignly failing CI tests.
Please let me know if you can think of a better name for
SummaryStatsLess.ql.