Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Use macro call location as fall back in macro expansions #19217

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Apr 4, 2025

Fixes all the AST inconsistencies reported by DCA.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Apr 4, 2025
@hvitved hvitved force-pushed the rust/macro-expansion-inherit-location branch from ad21b94 to 5731fa9 Compare April 4, 2025 09:38
@hvitved hvitved marked this pull request as ready for review April 4, 2025 13:13
@Copilot Copilot bot review requested due to automatic review settings April 4, 2025 13:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • rust/ql/lib/codeql/rust/elements/internal/LocatableImpl.qll: Language not supported
  • rust/ql/lib/codeql/rust/internal/AstConsistency.qll: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@hvitved hvitved requested a review from geoffw0 April 4, 2025 13:13
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, amazing! 🎉

@hvitved hvitved merged commit 006cb02 into github:main Apr 4, 2025
16 checks passed
@hvitved hvitved deleted the rust/macro-expansion-inherit-location branch April 4, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants