C++: Limit flow through sinks and sources in cpp/upcast-array-pointer-arithmetic#19434
Merged
jketema merged 2 commits intogithub:mainfrom May 1, 2025
Merged
C++: Limit flow through sinks and sources in cpp/upcast-array-pointer-arithmetic#19434jketema merged 2 commits intogithub:mainfrom
cpp/upcast-array-pointer-arithmetic#19434jketema merged 2 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the CastArrayPointerArithmetic dataflow query by preventing flow through both source and sink nodes and updates the expected test outputs accordingly.
- Added
isBarrierInandisBarrierOutpredicates to treat sources and sinks as barriers in the dataflow config. - Removed obsolete expected edges and subpaths from the test output to match the new barrier behavior in
CastArrayPointerArithmetic.expected.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/ql/src/Likely Bugs/Conversion/CastArrayPointerArithmetic.ql | Defined source and sink nodes as barriers (isBarrierIn/isBarrierOut) |
| cpp/ql/test/query-tests/Likely Bugs/Conversion/CastArrayPointerArithmetic/CastArrayPointerArithmetic.expected | Removed expected edges and subpaths that are now blocked by the new barrier logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.