Go: Make type param test independent of standard library version#19532
Merged
owen-mc merged 1 commit intogithub:mainfrom May 28, 2025
Merged
Go: Make type param test independent of standard library version#19532owen-mc merged 1 commit intogithub:mainfrom
owen-mc merged 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the type parameter test so it only counts entities with source locations, preventing standard library additions from affecting results.
- Adds an
exists(ty.getLocation())check to the query predicate to filter out stdlib types without location metadata. - Cleans up the expected output by removing entries for standard library functions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/ql/test/library-tests/semmle/go/Function/TypeParamType.ql | Added location-existence filter and comment explaining it |
| go/ql/test/library-tests/semmle/go/Function/TypeParamType.expected | Removed unsupported standard library entries |
This will make the test results not depend on the version of the standard library being used, which means we don't have to update it with each new release.
owen-mc
force-pushed
the
go/make-test-version-independent
branch
from
80999d9 to
f6f6a5c
Compare
mbg
approved these changes
May 28, 2025
Member
mbg
left a comment
mbg
left a comment
There was a problem hiding this comment.
Thanks for finding a neat solution for this! Makes sense to me and should make our lives easier going forward 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the test results not depend on the version of the standard library being used, which means we don't have to update it with each new release.