JS: Explicitly Filter Quality Queries for Inclusion in Security-and-Quality#19578
Merged
Napalys merged 2 commits intogithub:mainfrom May 27, 2025
Merged
JS: Explicitly Filter Quality Queries for Inclusion in Security-and-Quality#19578Napalys merged 2 commits intogithub:mainfrom
Security-and-Quality#19578Napalys merged 2 commits intogithub:mainfrom
Conversation
Napalys
force-pushed
the
js/security_quality_suite
branch
from
01d4fd3 to
52a15df
Compare
Napalys
force-pushed
the
js/security_quality_suite
branch
from
52a15df to
37024ad
Compare
Contributor
michaelnebel
left a comment
michaelnebel
left a comment
There was a problem hiding this comment.
Thx!
Maybe consider removing the parts of the filtering that does't have any effect for JS.
javascript/ql/src/codeql-suites/javascript-security-and-quality.qls
Outdated
Show resolved
Hide resolved
…y.qls Co-authored-by: Michael Nebel <michaelnebel@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR explicitly hardcodes all the quality query IDs within the
JavaScriptsecurity and quality suite. Similar to #19245