Rust: Update RegexInjectionExtensions to use getCanonicalPath.

[geoffw0]

Update RegexInjectionExtensions.qll to use getCanonicalPath rather than getResolvedPath + getResolvedCrateOrigin.

@hvitved please confirm that this is the right direction we want to move in.

[Copilot]

Pull Request Overview

Updates the NewSink class in RegexInjectionExtensions.qll to leverage getCanonicalPath for matching regex instantiations, replacing the previous getResolvedCrateOrigin + getResolvedPath approach.

• Switch filtering to getCanonicalPath on the Addressable target
• Replace CallExprCfgNode + PathExpr with CallExprBase + Addressable
• Adjust argument extraction to use getArg(0) and refine literal exclusion

Comments suppressed due to low confidence (3)

rust/ql/lib/codeql/rust/security/regex/RegexInjectionExtensions.qll:57

• [nitpick] Using getStaticTarget() may not capture macro-generated or dynamically-resolved targets; verify that all intended call sites are still covered with this change.

call.getStaticTarget() = a and

rust/ql/lib/codeql/rust/security/regex/RegexInjectionExtensions.qll:53

• Consider adding or updating unit tests for NewSink to validate matching behavior with getCanonicalPath and prevent regressions.

private class NewSink extends Sink {

rust/ql/lib/codeql/rust/security/regex/RegexInjectionExtensions.qll:56

• [nitpick] Switching from CallExprCfgNode to CallExprBase broadens matching to non-CFG call expressions; if the sink is intended for CFG nodes only, consider using CallExprCfgNode to maintain the original scope.

exists(CallExprBase call, Addressable a |

[hvitved]

Great!