C++: WIP: more conservative resolveClass #198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also exclude templates as their names are not canonical. The test change here is the inverse of what we got in 34c9892, which should be a good thing.
ian-semmle
approved these changes
Sep 17, 2018
|
Running CPP differences job here: https://jenkins.internal.semmle.com/job/Query-Changes/job/CPP-Differences/410/console. I'll close this PR to make sure nothing's merged before it's ready. |
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Jan 17, 2022
…ypes Fix inner generic type extraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR just to run the tests and to put a foot in the door for this fix, which needs to go into 1.18 in some form.