Java: Add query to detect non-case labels in switch statements#19998
Merged
tamasvajk merged 2 commits intogithub:mainfrom Jul 10, 2025
Merged
Java: Add query to detect non-case labels in switch statements#19998tamasvajk merged 2 commits intogithub:mainfrom
tamasvajk merged 2 commits intogithub:mainfrom
Conversation
tamasvajk
added
no-change-note-required
owen-mc
reviewed
Jul 9, 2025
subatoi
previously approved these changes
Jul 10, 2025
Contributor
subatoi
left a comment
subatoi
left a comment
There was a problem hiding this comment.
I agree with the suggestions from Owen but otherwise looks good 👍
owen-mc
approved these changes
Jul 10, 2025
Contributor
|
Tagging @knewbury01 for awareness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new CodeQL query for detecting non-case labels in Java
switchstatements, which can be confusing or indicative of bugs.This query was migrated from the internal repo. I somewhat changed the query to report two alert messages depending on whether the found label is used or not.
I've manually checked autofix suggestions on a couple of repos. Autofix can suggest both the trivial missing
casekeyword, and also can refactor the code, and move it into a separate method, and then call that method. (I guess the latter has some limitations, but my samples were relatively simple)