Java: Fix accidental CP in CFG for asserts.#20091
Merged
aschackmull merged 1 commit intogithub:mainfrom Jul 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an accidental cartesian product in the control flow graph (CFG) implementation for Java assert statements. The issue was causing the query optimizer to select inefficient join orders, significantly impacting performance.
- Replaces direct pattern matching with
NormalCompletion()with explicit variable binding and constraint - Eliminates cartesian product between completions and assert statements in the query execution plan
- Improves query performance by enabling better join order selection
owen-mc
approved these changes
Jul 18, 2025
Contributor
Author
|
Dca indicates a slight performance improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The somewhat recent change to the CFG for Java assert statements introduced an accidental cartesian product. The product is between completions and assert statements, both of which are somewhat limited in number, which is why we haven't discovered this before now. It was identified by the join-order metric, since the CP was confusing the optimiser to select a particularly bad join order.
Before:
After: