Shared/Cfg: Fix missing JoinBlockPredecessor.#20457
Merged
aschackmull merged 2 commits intogithub:mainfrom Sep 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where annotated exit nodes in singleton basic blocks were not being recognized as JoinBlockPredecessors, which caused incorrect control flow analysis when using splitting.
- Adds a missing case to handle annotated exit nodes as join block predecessors
- Ensures singleton basic blocks containing annotated exit nodes are properly included in control flow splitting
- Assigns appropriate kind values (2 for normal exit, 3 for non-normal exit) to distinguish exit node types
Contributor
Author
|
dca is uneventful |
aschackmull
added
the
no-change-note-required
paldepind
approved these changes
Sep 18, 2025
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Thanks for fixing this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the cases where an annotated exit node is a singleton basic block, then it failed to show up as a JoinBlockPredecessor of the exit node. This manifested in spurious controls-tuples involving the exit block when controls was calculated on top of splitting.