C#: * on Source locations in BMN.
#20555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/staridlocationsbuildless
branch
4 times, most recently
from
bae56f5 to
3f12101
Compare
michaelnebel
force-pushed
the
csharp/staridlocationsbuildless
branch
from
3f12101 to
3ee0e14
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michaelnebel
force-pushed
the
csharp/staridlocationsbuildless
branch
from
3ee0e14 to
199099c
Compare
michaelnebel
force-pushed
the
csharp/staridlocationsbuildless
branch
from
054a3a1 to
9ec0c9d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the C# extractor to use star IDs (* IDs) for source locations when extracting in BMN (Build Mode None) mode. The change is designed to improve extraction performance by reducing TRAP file size and eliminating location de-duplication overhead while maintaining transparency to end-users.
- Added logic to use star IDs (
*) instead of traditional location IDs when in standalone extraction mode - Updated location ID writing methods to conditionally output star IDs
- Added change notes documenting the performance improvement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csharp/ql/lib/change-notes/2025-10-10-starid-locations.md | Documents the change to use star IDs for location extraction with performance benefits |
| csharp/extractor/Semmle.Extraction.CSharp/Entities/Locations/NonGeneratedSourceLocation.cs | Implements conditional star ID writing for both quoted and unquoted location IDs in standalone mode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we change the extractor to use
*IDs for locations when extracting in BMN.DCA looks good.