JS: deprecate member lookup on static types #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the predicates
Type.getPropertyand variants ofType.getMemberand stops extracting the underlying relation, speeding up extraction by about 50%.The only use-case ever to emerge was to recognize
PromiseType, which is only used injs/missing-await. To minimize the fallout of this change, I decided to retain the behaviour ofPromiseTypevia an internal-only API.The type graph is infinite in general and so we were always limited to extracting only a subset of that graph. That subset has gradually gotten smaller and smaller, and while I don't think it was originally this expensive, TypeScript has evolved and it's just not a sensible thing to do any more, especially given the lack of use cases.