Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript: Teach Unused{Variable,Parameter} to ignore variables with leading underscore. #656

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

xiemaisi
Copy link

Fixes #655.

@xiemaisi xiemaisi added the JS label Dec 11, 2018
@xiemaisi xiemaisi requested a review from a team as a code owner December 11, 2018 08:53
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Interestingly, the destructuring pattern with _ will hide the lodash library if it is in scope :).

@xiemaisi
Copy link
Author

Heh, indeed it will.

@semmle-qlci semmle-qlci merged commit 06dd5f3 into github:master Dec 12, 2018
@xiemaisi xiemaisi deleted the js/unused-local-underscore branch January 1, 2019 09:17
cklin pushed a commit that referenced this pull request May 23, 2022
Release preparation for version 2.7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants