Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check-status): add null check for commit status rollup #41

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix(check-status): add null check for commit status rollup #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0e64e7
fix(check-status): add null check for commit status rollup
capthiron Oct 19, 2023
4e299dc
chore: make info message more descriptive
capthiron Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/functions/check-status.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,15 @@ export async function checkStatus(
// Check for CI status
if (mustBeGreen) {
const [{commit}] = result.repository.pullRequest.commits.nodes
const state = commit.statusCheckRollup.state
core.info('Validating status: ' + state)
if (state !== 'SUCCESS') {
core.info('Discarding ' + branch + ' with status ' + state)
if (commit.statusCheckRollup) {
const state = commit.statusCheckRollup.state
core.info('Validating status: ' + state)
if (state !== 'SUCCESS') {
core.info('Discarding ' + branch + ' with status ' + state)
statusOK = false
}
} else {
core.info('No status check associated with branch: ' + branch)
statusOK = false
}
}
Expand Down
Loading