EMU username schema is rejected by regex validation

[adrianokaiser]

Describe the Issue

I am currently using GitHub Cloud with an EMU setup. If i provide my username in the allowlist, the action tries to validate the username and rejects it. To my understanding the action is validating the username string with a Regex. That Regex was created in a different Repo which was created 7 years ago and so the regex is not covering the EMU username naming schema.

command/src/functions/allowlist.js

Line 102 in e566000

if (githubUsernameRegex.test(operator)) {

https://github.com/shinnn/github-username-regex/blob/master/index.js

In my EMU Organization the naming schema is:
localPartOfEmail_GitHubOrganizationName

Example:
Org name: DeepThought
E-Mail: arthur@deepthought.test

So the username will be:
arthur_deepthought

I cant tell if the username in EMU is something consistent.

Action Configuration

- name: command
  id: command
  uses: github/command@v0.0.3
  with:
    command: .zap
    allowlist: arthur_deepthought

Relevant Actions Log Output

No response

Extra Information

No response

[GrantBirki]

@adrianokaiser Thank you for raising this issue! EMU handle validation was something I had not even considered when writing this Action. EMU handles don't actually pass the traditional GitHub dotcom handle schema so we will need to do something custom here to ensure that works for this case.

Let me ask internally to see if there is a consistent pattern we can use to solve this. Thanks! ❤️

[GrantBirki]

I think the following regex for EMU handles will work:

/\A[a-zA-Z0-9]+(-[a-zA-Z0-9]+)*-?_[a-zA-Z0-9]+\z/i

This worked for most of the test cases that I tried and it also worked for your handle + EMU for your org:

https://rubular.com/r/cHfCcF6V7L5Vqy

[GrantBirki]

Since that upstream npm package hasn't been updated in ~7 years, I'm going to fork it and create a better supported one that covers EMUs to solve this problem for this Action but also for other developers in the wild

https://github.com/GrantBirki/github-username-regex

[GrantBirki]

@adrianokaiser I just pushed a new pre-release for this Action that should contain the fix for this issue. Please give v1.1.0 a go and let me know if it works, thanks!

[GrantBirki]

I will go ahead and close this out and publish the release as latest