Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#43 skip_completing ignores true value and completes #44

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

walkerk1980
Copy link
Contributor

#43

@GrantBirki
Copy link
Member

GrantBirki commented Oct 11, 2024

Hey @walkerk1980 thank you for this PR! The file you are trying to edit (dist/index.js), is actually a file that gets auto generated when running npm run all after making changes to the source files. The actual file you will need to edit is this one:

if (skip_completing === 'true') {

After editing this file please ensure to run npm run test and npm run all to ensure everything works as expected, and commit the auto-generated file changes. Thanks! 🙇

@walkerk1980
Copy link
Contributor Author

walkerk1980 commented Oct 14, 2024

Hey @walkerk1980 thank you for this PR! The file you are trying to edit (dist/index.js), is actually a file that gets auto generated when running npm run all after making changes to the source files. The actual file you will need to edit is this one:

if (skip_completing === 'true') {

After editing this file please ensure to run npm run test and npm run all to ensure everything works as expected, and commit the auto-generated file changes. Thanks! 🙇

Sorry, I didn't bother to read CONTRIBUTING.md before. 🤦

Force pushed a new commit.

@GrantBirki GrantBirki added the bug Something isn't working label Oct 14, 2024
@GrantBirki GrantBirki merged commit ca43e96 into github:main Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants