Fix ask-user test snapshots #319
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ask-user test snapshots so they match the current GitHub Copilot CLI v0.0.400 behavior for freeform ask_user responses, unblocking timeouts in multiple SDK test suites.
Changes:
- Align freeform tool message content from
"User response (freeform): ..."to"User responded: ..."across all ask-user snapshot variants. - Add
allow_freeform: trueto theask_usertool arguments in theaskusersnapshot so all variants model the freeform flow consistently. - Normalize the final assistant message in the ask-user freeform snapshot to match the updated conversation wording.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/snapshots/askuser/should_handle_freeform_user_input_response.yaml |
Updates the tool content to "User responded: ..." and adds allow_freeform: true to match the freeform CLI behavior. |
test/snapshots/ask_user/handle_freeform_user_input_response.yaml |
Updates the tool content string to the new "User responded: ..." format for consistency. |
test/snapshots/ask-user/should_handle_freeform_user_input_response.yaml |
Updates the tool content and the assistant’s final message text to align this snapshot with the current CLI output and other snapshots. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
friggeri
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ask-user test snapshots no longer match what GitHub Copilot CLI v0.0.400 outputs.
Fixes #315.