fix: clear timeout timer in sendAndWait to prevent process hang #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When idlePromise resolved first (successful response), the setTimeout timer kept running in the background, preventing Node.js from exiting until the timer fired. Fixes #136
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where the Node.js process would hang after client.stop() was called due to an uncancelled timeout timer in the sendAndWait method. When the session became idle (successful response), the setTimeout timer continued running in the background, preventing the process from exiting until the timer expired.
Changes:
- Capture the timeout ID from
setTimeoutin thesendAndWaitmethod - Clear the timeout in the finally block to ensure cleanup in all code paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When idlePromise resolved first (successful response), the setTimeout timer kept running in the background, preventing Node.js from exiting until the timer fired.
Fixes #136