Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does "the official Octokit library" mean? #14926

Closed
1 task done
solvaholic opened this issue Feb 1, 2022 · 10 comments · Fixed by #26058
Closed
1 task done

What does "the official Octokit library" mean? #14926

solvaholic opened this issue Feb 1, 2022 · 10 comments · Fixed by #26058
Labels
content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue rest Content related to rest - overview.

Comments

@solvaholic
Copy link
Contributor

solvaholic commented Feb 1, 2022

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/rest/overview/libraries

What part(s) of the article would you like to see updated?

I'd like to see clarification around what it means for Octokit to be an official library and/or removal of octokit/octokit.js as an official library.

When Dependabot calls out a vulnerability in octokit.js, it being documented as "the official Octokit library" suggests GitHub will do things to address the vulnerability. I'd like to see this document clarify whether that's the case.

Additional information

I read "the official Octokit library" in GitHub's documentation to mean GitHub endorses and supports users' use of Octokit, and may sponsor maintenance of the library's projects. I struggle to imagine the official library being un-maintained.

Last year @gr2m explained:

The JavaScript Octokit has no active maintainer as of this week.

Last week @wolfy1339 added:

Also, the octokit modules are unmaintained.

This raises concerns like octokit/core.js#442 (comment) about the viability of the project.

Update and content plan

Updates and plan

@solvaholic solvaholic added the content This issue or pull request belongs to the Docs Content team label Feb 1, 2022
@welcome
Copy link

welcome bot commented Feb 1, 2022

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 1, 2022
@ramyaparimi ramyaparimi added rest Content related to rest - overview. waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 2, 2022
@ramyaparimi
Copy link
Contributor

@solvaholic
Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@skedwards88
Copy link
Contributor

Thanks for opening this issue! The octokit libraries are not currently maintained. This may change in the future. You or anyone else is welcome to open a PR to update the documentation to indicate that the octokit libraries are not currently maintained.

@skedwards88 skedwards88 added the help wanted Anyone is welcome to open a pull request to fix this issue label Feb 7, 2022
@skedwards88 skedwards88 removed the waiting for review Issue/PR is waiting for a writer's review label Feb 7, 2022
@june1963
Copy link
Contributor

june1963 commented Feb 7, 2022

Octokit is temporarily unmaintained and per: https://github.com/github/c2c-actions/issues/3872 we will be hiring for headcount to support Octokit officially with an SDK team, with date TBD. I think it would be worth adding a small text blurb mentioning its current state of support, though I'm not sure what the right wording for this would be. Perhaps something akin to (which should also be added to the README of the repositories):

Note: Octokit is not actively maintained currently. Please remain patient while we work on an announcement regarding the state of Octokit's future.

@imwiss
Copy link
Contributor

imwiss commented Feb 9, 2022

Thanks everyone for chiming in. I posted an update about Octokit's future here: octokit/octokit.js#620 (comment)

@thispsj
Copy link
Contributor

thispsj commented Jun 20, 2022

This is the latest update on Octokit.js.

@solvaholic
Copy link
Contributor Author

What does "the official Octokit library" mean?

I think it means GitHub endorses and supports users' use of Octokit, and may sponsor maintenance of the library's projects.

The published doc currently lists 3 libraries as official. When users want help I think they may open issues or discussions in the project repositories, or they may contact GitHub Support. How should users request help?

Whichever is the preferred approach, I'd like to see docs in each repo, for example a SUPPORT.md, clearly state those expectations and instructions. What can I do to help make that happen?

@skedwards88
Copy link
Contributor

Thanks everyone for this discussion! The Octokit libraries are now maintained again, and the maintainers are working on adding SUPPORT.md files, addressing security vulnerabilities, and cleaning up the projects.

  • If you have a specific Octokit issue, you should open an issue in the corresponding Octokit repo. While these repos are maintained by GitHub, they are open source and community contribuitons are welcome.
  • Anyone is welcome to open a pull request to add the info in this point ☝️ to https://docs.github.com/en/rest/overview/libraries

@cmwilson21 cmwilson21 added the MLH fellowship This issue is reserved for the MLH Fellowship program label Dec 28, 2022
@cmwilson21 cmwilson21 removed the help wanted Anyone is welcome to open a pull request to fix this issue label Jan 9, 2023
@github-actions
Copy link
Contributor

A stale label has been added to this issue becuase it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Mar 11, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2023
@cmwilson21
Copy link
Contributor

Reopening as stale bot closed this a bit early.

@cmwilson21 cmwilson21 reopened this Mar 13, 2023
@cmwilson21 cmwilson21 removed the stale There is no recent activity on this issue or pull request label Mar 13, 2023
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 13, 2023
@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Mar 13, 2023
@cmwilson21 cmwilson21 added help wanted Anyone is welcome to open a pull request to fix this issue and removed MLH fellowship This issue is reserved for the MLH Fellowship program labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue rest Content related to rest - overview.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants
@imwiss @solvaholic @june1963 @skedwards88 @ramyaparimi @thispsj @cmwilson21 and others