-
Notifications
You must be signed in to change notification settings - Fork 62.5k
Closed
yahya2033/docs
#4Labels
contentThis issue or pull request belongs to the Docs Content teamThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem teamThis issue or pull request should be reviewed by the Docs Ecosystem teamgood first issueGood for newcomersGood for newcomershelp wantedAnyone is welcome to open a pull request to fix this issueAnyone is welcome to open a pull request to fix this issue
Description
What is the current behavior?
The docs for the Events API says the following:
Events support pagination, however the per_page option is unsupported. The fixed page size is 30 items. Fetching up to ten pages is supported, for a total of 300 events. For information, see "Traversing with pagination."
However, each of the API's does document a per_page
parameter and it does seem to work fine:
$ curl -s https://api.github.com/repos/wayofthepie/ctlogs-cli/events?per_page=12 | jq '. | length'
12
What changes are you suggesting?
It seems like the section mentioning per_page
is unsupported should be removed, if per_page
is indeed meant to work for the Events
API.
Metadata
Metadata
Assignees
Labels
contentThis issue or pull request belongs to the Docs Content teamThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem teamThis issue or pull request should be reviewed by the Docs Ecosystem teamgood first issueGood for newcomersGood for newcomershelp wantedAnyone is welcome to open a pull request to fix this issueAnyone is welcome to open a pull request to fix this issue