Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum access by forked repos is inaccurate #22493

Closed
1 task done
jsoref opened this issue Dec 6, 2022 · 4 comments · Fixed by #22730
Closed
1 task done

Maximum access by forked repos is inaccurate #22493

jsoref opened this issue Dec 6, 2022 · 4 comments · Fixed by #22730
Assignees
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review

Comments

@jsoref
Copy link
Contributor

jsoref commented Dec 6, 2022

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

What part(s) of the article would you like to see updated?

As noted in #22492, Maximum access by forked repos really means Maximum access for pull requests from forked repos.

But, beyond that, https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#enabling-workflows-for-forks-of-private-repositories says:

Available to private repositories only, you can configure these policy settings for organizations, or repositories.
...
Send write tokens to workflows from pull requests - Allows pull requests from forks to use a GITHUB_TOKEN with write permission.

Thus, the correct text would be Maximum access for pull requests to public repositories from forked repos.

I know that's a mouthful and too much to stick into a column heading, but the current text is fairly misleading and finding all the caveats is not fun.

Additional information

PowerDNS/pdns#12249 (comment)

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Dec 6, 2022
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 6, 2022
@cmwilson21
Copy link
Contributor

👋 @jsoref - Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@cmwilson21 cmwilson21 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Dec 7, 2022
@nawed2611
Copy link
Contributor

Hey, I would like to work on this

@jsoref
Copy link
Contributor Author

jsoref commented Dec 14, 2022

I wouldn't suggest picking this up until the waiting for review label is removed.

If you're looking for something to pick up, might I suggest:
https://github.com/github/docs/issues?q=is%3Aopen+is%3Aissue+author%3Ajsoref+label%3A%22help+wanted%22

@lucascosti
Copy link
Contributor

Thanks for pointing this out, @jsoref. Because this was slightly complicated to implement, i've opened a PR to fix in #22730.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants