Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary comma in private forks test #22494

Closed
1 task done
jsoref opened this issue Dec 6, 2022 · 3 comments · Fixed by #22666
Closed
1 task done

Remove unnecessary comma in private forks test #22494

jsoref opened this issue Dec 6, 2022 · 3 comments · Fixed by #22666
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise help wanted Anyone is welcome to open a pull request to fix this issue repositories Content related to repositories

Comments

@jsoref
Copy link
Contributor

jsoref commented Dec 6, 2022

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#enabling-workflows-for-forks-of-private-repositories

What part(s) of the article would you like to see updated?

If you rely on using forks of your private repositories, you can configure policies that control how users can run workflows on pull_request events. Available to private repositories only, you can configure these policy settings for organizations, or repositories.

If you can set this knob for enterprises, the text should say so.

If you can't set it for enterprises, the text should say so.

Additional information

#22493

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Dec 6, 2022
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 6, 2022
@cmwilson21 cmwilson21 added enterprise Content relating to GitHub Enterprise repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 7, 2022
@cmwilson21
Copy link
Contributor

👋 @jsoref - Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@jsoref
Copy link
Contributor Author

jsoref commented Dec 7, 2022

I suppose I should note that as-is the text has a , for a list of 2 items (organizations and repositories) which is wrong the comma will only apply once there's a third item (enterprises) 🙂 .

@lucascosti
Copy link
Contributor

👋 @jsoref, thanks for opening this issue. The article does mention enterprises, but only if you are viewing the article for an enterprise product (we try not to mention enterprise options unless it's applicable to the docs someone is viewing):

image

I suppose I should note that as-is the text has a , for a list of 2 items (organizations and repositories) which is wrong the comma will only apply once there's a third item (enterprises) 🙂 .

Great pickup! The unnecessary comma there is fine on an enterprise page, but not on a non-enterprise page. That comma should be versioned only for viewing an enterprise page. I'll update the title of the issue.

You can find that paragraph in this reusable: https://github.com/github/docs/blob/main/data/reusables/actions/private-repository-forks-overview.md#L0-L1

Feel free for you, or anyone else, to open a PR to fix this 🙇‍♂️

@lucascosti lucascosti changed the title Enabling workflows for forks of private repositories doesn't mention enterprises Remove unnecessary comma in private forks test Dec 12, 2022
@lucascosti lucascosti added the help wanted Anyone is welcome to open a pull request to fix this issue label Dec 12, 2022
@cmwilson21 cmwilson21 removed the waiting for review Issue/PR is waiting for a writer's review label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise help wanted Anyone is welcome to open a pull request to fix this issue repositories Content related to repositories
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants