Skip to content

Cannot reproduce behavior documented in pull_request.synchronize #23051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
christianbundy opened this issue Jan 6, 2023 · 5 comments
Closed
1 task done
Labels
content This issue or pull request belongs to the Docs Content team developers Content related to developers waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks

Comments

@christianbundy
Copy link

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads?actionType=synchronize#pull_request

What part(s) of the article would you like to see updated?

Unfortunately, I don't think the documentation is correct -- can someone double-check me here?

A pull request's head branch was updated. For example, the head branch was updated from the base branch, new commits were pushed to the head branch, or the base branch was changed.

Specifically, I cannot reproduce the "or the base branch was changed" logic.

Steps:

  1. Open PR with action on pull_request
  2. Workflow runs because of the opened event
  3. Edit PR to change base branch from main to some_other_ref (different SHA)

Expected: CI should run because the base branch has changed.

Actual: CI does not run.

Additional information

No response

@christianbundy christianbundy added the content This issue or pull request belongs to the Docs Content team label Jan 6, 2023
@welcome
Copy link

welcome bot commented Jan 6, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 6, 2023
@christianbundy
Copy link
Author

Reviewing our recent webhooks, it seems that this is actually kicking off an edited event. Is it possible that changing base branch actually emits the edited event rather than synchronize?

The title or body of a pull request was edited.

-- https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads?actionType=edited#pull_request

However, looking at the schema of the event shows the base branch as part of the 'changes' payload:

image

@cmwilson21
Copy link
Contributor

@christianbundy Thanks so much for opening an issue! We appreciate all the info and screenshots 💖

I'll triage this for the team to take a look 👀

@cmwilson21 cmwilson21 added waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks developers Content related to developers and removed triage Do not begin working on this issue until triaged by the team labels Jan 9, 2023
@skedwards88
Copy link
Contributor

Thanks for opening this issue! I also was unable to trigger the "synchronize" action by changing the base branch of a PR. We need to update these docs internally, so I'm going to add a label to start that process.

@docubot
Copy link
Contributor

docubot commented Jan 11, 2023

Thank you for opening this issue! Updates to the REST/GraphQL API description must be made internally. I have copied your issue to an internal issue, so I will close this issue.

@docubot docubot closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team developers Content related to developers waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks
Projects
None yet
Development

No branches or pull requests

4 participants