Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove periods from list in managing-deploy-keys#pros-of-installation-access-tokens #34522

Closed
1 task done
Tracked by #34542
nguyenalex836 opened this issue Sep 6, 2024 · 2 comments · Fixed by #34540
Closed
1 task done
Tracked by #34542

Remove periods from list in managing-deploy-keys#pros-of-installation-access-tokens #34522

nguyenalex836 opened this issue Sep 6, 2024 · 2 comments · Fixed by #34540
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team good first issue Good for newcomers

Comments

@nguyenalex836
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/authentication/connecting-to-github-with-ssh/managing-deploy-keys#pros-of-installation-access-tokens

What part(s) of the article would you like to see updated?

Pros of installation access tokens

  • Tightly-scoped tokens with well-defined permission sets and expiration times (1 hour, or less if revoked manually using the API).
  • Dedicated rate limits that grow with your organization.
  • Decoupled from GitHub user identities, so they do not consume any licensed seats.
  • Never granted a password, so cannot be directly signed in to.

Periods need to be removed from each list line, as each line is not a complete sentence (per our style guide)

Additional information

No response
@nguyenalex836 nguyenalex836 added good first issue Good for newcomers content This issue or pull request belongs to the Docs Content team authentication Content relating to authentication labels Sep 6, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 6, 2024
@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Sep 6, 2024
dominicghizzoni added a commit to dominicghizzoni/docs that referenced this issue Sep 6, 2024
@dominicghizzoni
Update managing-deploy-keys.md
f04282d 
I removed the periods as mentioned in issue github#34522
@Abebayew

This comment was marked as spam.

Sign in to view
@gonmmarques gonmmarques mentioned this issue Sep 9, 2024
Merged
2 tasks
@nguyenalex836
Copy link
Contributor Author

Closing as the following PR will address this issue once merged (when repo freeze ends on 9/16) - #34540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Remove periods from Managing deploy keys list gonmmarques/docs
3 participants
@nguyenalex836 @Abebayew and others