Blue link text in notices is unreadable due to blue background

[zeke]

What is the current behavior?

What changes are you suggesting?

Use a more visible link color in notices.

[janiceilene]

Thanks so much for opening an issue to let us know @zeke! I've triaged it for the engineering team to take a look 👀

[adityadees]

Thanks so much for opening an issue to let us know @zeke! I've triaged it for the engineering team to take a look

is it still open?

[zeke]

I still see this issue at https://docs.github.com/cn

[chiedo]

We've got it added to our short-term list of bugs to fix as of today!

[lucalves]

I would like to work on that. What is the ideal color to include in the notice links? @chiedo @janiceilene

[lucalves]

I still see this issue at https://docs.github.com/cn

This problem with the link and the blue background, is repeated in all other notices. Look at the docs in Portuguese, Japanese and Chinese.

I can work on this if it is defined what will be the new color for the links in the notices.

[chiedo]

Thank you @lucalves! @janiceilene and @myarb, @emilyistoofunky and I are thinking that maybe we just set the background to a lighter blue so we don't have to change the link color? --color-bg-info from https://primer.style/css/support/color-system#backgrounds

What do you think?

@lucalves do you want to spike that change?

[lucalves]

Thank you @lucalves! @janiceilene and @myarb, @emilyistoofunky and I are thinking that maybe we just set the background to a lighter blue so we don't have to change the link color? --color-bg-info from https://primer.style/css/support/color-system#backgrounds

What do you think?

@lucalves do you want to spike that change?

I can try to make that change. If everyone agrees that it will be this color :)

[lee-dohm]

Thanks for being willing to assist @lucalves! We're investigating whether the suggestion that @chiedo mentions is the right way to go. Would you mind opening a PR with the suggested change so that we can take a look and see if it works?

Let me know if you have any questions!

[lucalves]

Hello @lee-dohm, I opened PR #5781, to solve this. I don't know why, but when deploying Heroku, I can't verify the pages other than the English page.

[chiedo]

I'll see if I can get cn working on the staging branch. One sec!

[chiedo]

You should be good to continue @lucalves!

https://docs-5781--hotfixnotices-link.herokuapp.com/cn works.

[zeke]

Thanks for the fix @lucalves ✨

[chiedo]

Thanks @lucalves for working with us on this!

[myarb]

This looks great! 🎉 Thanks, @lucalves ✨

[lucalves]

Thank you all, now it really got a lot better! @zeke @chiedo @myarb