Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link on liquid helpers #1033

Merged
merged 4 commits into from
Nov 4, 2020
Merged

Fix broken link on liquid helpers #1033

merged 4 commits into from
Nov 4, 2020

Conversation

WilliamChang80
Copy link
Contributor

Why:

I get 404 when open liquid helpers page from contributing.md

What's being changed:

Fix path for liquid helpers

Check off the following:

@janiceilene
Copy link
Contributor

Thanks so much @WilliamChang80! I'll update the branch and get this merged as soon as tests are green 🍏

@WilliamChang80
Copy link
Contributor Author

Is there any problem with the CI? It takes too long for caching node_modules

@nschonni
Copy link
Contributor

nschonni commented Nov 4, 2020

@WilliamChang80 hitting the branch update button may unstick it

@WilliamChang80
Copy link
Contributor Author

@janiceilene ready to merge

@janiceilene janiceilene merged commit 036ddd0 into github:main Nov 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants