Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong "Create a commit comment" link in Pull Requests REST API page #11132

Merged
merged 5 commits into from
Nov 3, 2021
Merged

Conversation

Fs00
Copy link
Contributor

@Fs00 Fs00 commented Oct 12, 2021

Why:

Closes #11131

What's being changed:

Fixes the wrong link described in the issue above

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review labels Oct 13, 2021
@ramyaparimi
Copy link
Contributor

@Fs00
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Contributor

@ethanpalm ethanpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fs00, thanks for creating this PR! Your change looks great and will help people navigate to where they're expecting to go.

I'll get this branch up to date and merge it once all checks are passing ✨

Thanks for contributing to the GitHub docs!

@ethanpalm ethanpalm enabled auto-merge October 22, 2021 17:46
@ramyaparimi ramyaparimi added the ready to merge This pull request is ready to merge label Oct 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/rest/reference/pulls.md Modified Original

@ethanpalm ethanpalm merged commit 9fe38a0 into github:main Nov 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong "Create a commit comment" link
3 participants