Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry to table "create, edit, delete labels" #1180

Merged
merged 4 commits into from
Nov 30, 2020
Merged

Add entry to table "create, edit, delete labels" #1180

merged 4 commits into from
Nov 30, 2020

Conversation

HonkingGoose
Copy link
Contributor

Why:

Fixes #1178.

What's being changed:

  • Add entry to table "create, edit, delete labels"

Check off the following:

@janiceilene
Copy link
Contributor

👋 Thanks for opening a PR @HonkingGoose! I see that this is currently a draft, let me know when it's ready for review and I'll get it triaged 💖

@HonkingGoose HonkingGoose marked this pull request as ready for review November 10, 2020 08:58
@HonkingGoose
Copy link
Contributor Author

Hi @janiceilene 👋

This is ready for triage/review now.

@janiceilene
Copy link
Contributor

Thanks @HonkingGoose! I'll get it triaged ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 10, 2020
Copy link

@lashaunda lashaunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[link removed by moderator]

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@HonkingGoose

This comment has been minimized.

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 29, 2020
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 Hi @HonkingGoose

Many thanks for your patience with the very slow review. This looks like a great addition to the topic. ✨

While reviewing this change, I realized that an associated topic could also do with a minor update and opened: #1693 for it.

I'll update the branch from main and merge this PR 😄

@felicitymay felicitymay merged commit d7288d3 into github:main Nov 30, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@HonkingGoose
Copy link
Contributor Author

Cheers, thanks for merging @felicitymay. 😄

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* Document current limitation of multi-tenancy

* Update prometheus-multi-tenancy.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add row with create/edit/delete labels rights overview to permission level table
4 participants