-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSH file to "id_ed25519.pub" #1189
Conversation
It looks like the filename was changed in the "generating a new ssh key" document, and I figure this should be updated as well.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
This is not stale! Sorry about missing this one @servel333 💛 I'll get it triaged for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @servel333! 🎉
PS: The "Files changed" tab shows 0, but this is because an identical change was merged just before. Your contribution is still 100% valid!
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
It's worth noting that the instructions mention using both an RSA and the other one. These two docs may need further updates in order to resolve the issue of different key names on different systems, as well as addressing legacy keys that users already use. |
Thank you for pointing that out 👍🏽 There have been quite a few changes to these docs lately, so we're slowly getting them into a better shape. Feel free to open an issue if you see any immediate problems and places that might be confusing! Thanks again for taking the time to help us improve the docs, we appreciate the help 😊 |
Why:
It looks like the filename was changed in the "generating a new ssh key" document, and I figure this should be updated as well.
Ref: https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent
What's being changed:
Check off the following: