update name of secret

[lpmi-13]

When attempting to follow the guide and set a value for a secret called GITHUB_SECRET, the UI presented the following error:

"Failed to add secret. Secret names must not start with GITHUB_."

If this is not a valid naming convention for secrets, then we shouldn't use it in the documentation.

Why:

Closes #12094

What's being changed:

The name of the secret in the example.

Check off the following:

• I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
• For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

• This pull request impacts the contribution experience
  • I have added the 'writer impact' label
  • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

[welcome]

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

[github-actions]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

---

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source	Staging	Production	What Changed
content/actions/learn-github-actions/workflow-syntax-for-github-actions.md	Modified	Original

[ramyaparimi]

@lpmi-13
Thanks so much for opening a PR! I'll get this triaged for review ⚡

[felicitymay]

Hi @lpmi-13 👋🏻

Thank you so much for this update to the docs. You're right - this is a bad example. I'm not sure how it slipped through the review process 🙈

I'm going to make one change, but otherwise this looks good to merge 👍🏻

[felicitymay]

@lpmi-13 - I did a quick check of the rest of the docs and found some other places where we used the same example. 🤔

I'm checking internally that your change is correct before merging the change - just in case I've missed something important. It's possible that there are other places we should make the same fix.

[felicitymay]

@lpmi-13 - I'm glad that I checked with the Actions docs team 😌

It turns out that this example uses the special GITHUB_TOKEN that is created automatically for each workflow run. This is explained here: Automatic token authentication.

I'm glad that you raised this PR to highlight the confusion here 🙇🏻‍♀️
I'm going to report this to the team who maintain this area of the product and suggest that provide a tailored error message if someone tries to create a secret called GITHUB_TOKEN.

[lpmi-13]

A different error message would be very helpful. Thanks for the quick response on this 👍