Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add responsive to footer #1268

Merged
merged 2 commits into from
Nov 17, 2020
Merged

add responsive to footer #1268

merged 2 commits into from
Nov 17, 2020

Conversation

Arhell
Copy link
Contributor

@Arhell Arhell commented Nov 11, 2020

Why:

fix this issue #1267

What's being changed:

add responsive to footer

If you have any comments, write
review page:
https://docs-1268--fix-footer.herokuapp.com/en
after fix:
1

@Arhell Arhell marked this pull request as draft November 11, 2020 23:36
@Arhell Arhell marked this pull request as ready for review November 12, 2020 23:34
@Arhell
Copy link
Contributor Author

Arhell commented Nov 13, 2020

cc @janiceilene
cc @heiskr

@janiceilene
Copy link
Contributor

@Arhell Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added the engineering Will involve Docs Engineering label Nov 16, 2020
@chiedo
Copy link
Contributor

chiedo commented Nov 17, 2020

@simpsoka this looks good to me! You cool with it?

@simpsoka simpsoka self-requested a review November 17, 2020 15:54
Copy link
Contributor

@simpsoka simpsoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! cc @chiedo

@chiedo chiedo merged commit be16b0f into github:main Nov 17, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants