Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide to use branches instead of tags for serviceable releases #1413

Closed
wants to merge 10 commits into from
Closed

Guide to use branches instead of tags for serviceable releases #1413

wants to merge 10 commits into from

Conversation

AArnott
Copy link

@AArnott AArnott commented Nov 17, 2020

Git tags are not safe to redefine. An existing git clone does not download tags that are already known because git assumes that tags will never be redefined.
As it stood, this doc sounded like it advocated moving tags, which can cause lots of confusion in a team with many git clones.
With this change, I revise the use of tag/branch terms to make it clear that branches should move and tags should remain static.

Why:

What's being changed:

Check off the following:

@AArnott
Guide to use branches instead of tags for serviceable releases
4b38498 
Git tags are not safe to redefine. An existing git clone *does not download tags that are already known* because git assumes that *tags will never be redefined*. 
As it stood, this doc sounded like it advocated *moving tags*, which can cause lots of confusion in a team with many git clones.
With this change, I revise the use of tag/branch terms to make it clear that branches should move and tags should remain static.
@welcome
Copy link

welcome bot commented Nov 17, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@AArnott AArnott mentioned this pull request Nov 17, 2020
Closed
@janiceilene
Copy link
Contributor

@AArnott Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 19, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 27, 2020
@AArnott
Copy link
Author

AArnott commented Nov 27, 2020

@janiceilene How long before triage looks at this?

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@janiceilene
Copy link
Contributor

@AArnott It's triaged and waiting for the team. Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@AArnott
Copy link
Author

AArnott commented Dec 2, 2020

Thanks, @janiceilene. I got nervous when the bot threatened to close the issue.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 10, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 10, 2020
@martin389 martin389 self-assigned this Dec 14, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 21, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 21, 2020
@martin389
Copy link
Contributor

👋 Thank you for this contribution! I'm just checking these proposed changes with our support folks.

@AArnott
Copy link
Author

AArnott commented Dec 22, 2020

Thanks, @martin389. One question/concern I have is whether the GitHub Marketplace will list branches as "versions" that can be selected the way it does for tags. If it doesn't, that seems like a hole to fill.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 29, 2020
@martin389
Copy link
Contributor

Clearing stale status. ⏳

@martin389 martin389 removed the stale There is no recent activity on this issue or pull request label Dec 31, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 7, 2021
@martin389 martin389 removed the stale There is no recent activity on this issue or pull request label Jan 8, 2021
@martin389
Copy link
Contributor

Status update: Checking with reviewers ❤️

@martin389
Copy link
Contributor

Status update: Followed up with reviewers

@martin389
Copy link
Contributor

Following up on this 👍

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 27, 2021
@martin389 martin389 removed the stale There is no recent activity on this issue or pull request label Jan 28, 2021
@martin389
Copy link
Contributor

Clearing stale status. ⏳

@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@martin389
Copy link
Contributor

Clearing stale status. ⏳

@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@chiedo chiedo added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@martin389
Copy link
Contributor

Following up on this review 👀

@janiceilene
Copy link
Contributor

👋 @AArnott The devs and product management have gotten back to us, and they would like to keep the existing guidance in place for now, since they are currently looking at additional options on how to improve things in this space.

So sorry that we aren’t able to merge this PR, we really appreciate your interest in helping improve the Actions docs! 💛

@AArnott AArnott deleted the patch-1 branch March 18, 2021 23:55
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@charislam @Loquacity
[Cloud] Document authentication troubleshooting (github#1413)
7105ddc 
Old versions of JDBC drivers are not compatible with SCRAM
authentication, causing a problem when connecting with Timescale Cloud's
default settings. Document two potential solutions.

Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martin389 martin389

Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AArnott @janiceilene @martin389 @chiedo