Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Configuring a codespace for VS #1416

Merged
merged 4 commits into from
Nov 21, 2020
Merged

Update Configuring a codespace for VS #1416

merged 4 commits into from
Nov 21, 2020

Conversation

gregvanl
Copy link
Contributor

@gregvanl gregvanl commented Nov 18, 2020

Why:

Visual Studio devinit tool team requested changes to the section on Configuring a codespace for VS

What's being changed:

See PR for content changes

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Nov 18, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@gregvanl Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 19, 2020
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregvanl - Many thanks for submitting this PR. I've made a small suggestion for a change. Thanks again! 👍

@hubwriter hubwriter self-assigned this Nov 20, 2020
@hubwriter
Copy link
Contributor

@gregvanl - Thanks again for the update to this topic. Merging now.

@hubwriter hubwriter merged commit 5f8816f into github:main Nov 21, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants