Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include work around for wildcards in HTTP Proxy Exclusion list #1501

Merged
merged 8 commits into from
Jan 8, 2021
Merged

Include work around for wildcards in HTTP Proxy Exclusion list #1501

merged 8 commits into from
Jan 8, 2021

Conversation

mzzmjd
Copy link
Contributor

@mzzmjd mzzmjd commented Nov 20, 2020

Why:

What's being changed:

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Nov 20, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@mzzmjd
Copy link
Contributor Author

mzzmjd commented Nov 20, 2020

Link to #1501 1502

@mzzmjd mzzmjd marked this pull request as ready for review November 20, 2020 15:40
@janiceilene janiceilene linked an issue Nov 20, 2020 that may be closed by this pull request
Include work around for wildcards in HTTP Proxy Exclusion list on GHES #1502
Closed
@janiceilene
Copy link
Contributor

@mzzmjd Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 3, 2020
@github-actions github-actions bot closed this Dec 13, 2020
@brntbeer
Copy link
Member

@mzzmjd Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@mzzmjd Would you mind taking a look at the pull request template (here: https://raw.githubusercontent.com/github/docs/main/.github/PULL_REQUEST_TEMPLATE.md) and add it to your opening post so we can go about reviewing and merging this?

@brntbeer brntbeer reopened this Dec 22, 2020
@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Dec 23, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added stale There is no recent activity on this issue or pull request and removed stale There is no recent activity on this issue or pull request labels Dec 30, 2020
@martin389 martin389 self-assigned this Dec 31, 2020
@martin389
Copy link
Contributor

Summary

This PR addresses #1502

Changes in this PR

Article in staging Changes
“Configuring an outbound web proxy server” Adds a line to step 5, explaining how to use a wildcard for outbound proxy configuration.

Tests

All tests are passing! 🍏

@martin389 martin389 added content This issue or pull request belongs to the Docs Content team core labels Dec 31, 2020
@martin389
Copy link
Contributor

Checking this approach with the support team.

@martin389
Copy link
Contributor

Support have confirmed they're happy with this approach 👍 Now working on merging this PR.

@vutting4221 vutting4221 mentioned this pull request Sep 30, 2022
Open
This was referenced Sep 30, 2022
Open
Open
@ramsemune ramsemune mentioned this pull request Oct 5, 2022
Open
@shga1993 shga1993 mentioned this pull request Oct 5, 2022
Open
@dev2dark dev2dark mentioned this pull request Oct 5, 2022
Open
@zipzip225 zipzip225 mentioned this pull request Oct 5, 2022
Open
@Jsn2win Jsn2win mentioned this pull request Oct 5, 2022
Open
@onuronur76 onuronur76 mentioned this pull request Oct 5, 2022
Open
@machatman machatman mentioned this pull request Oct 5, 2022
Open
@onuronur76 onuronur76 mentioned this pull request Oct 6, 2022
Open
@treeations treeations mentioned this pull request Oct 6, 2022
Open
@machatman machatman mentioned this pull request Oct 6, 2022
Open
@trongham trongham mentioned this pull request Oct 6, 2022
Open
@ramsemune ramsemune mentioned this pull request Oct 6, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@shga1993 shga1993 mentioned this pull request Oct 6, 2022
Open
@ayvazjet ayvazjet mentioned this pull request Oct 7, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 7, 2022
Open
@treeations treeations mentioned this pull request Oct 7, 2022
Open
@bonachylauriel bonachylauriel mentioned this pull request Oct 7, 2022
Open
@trongham trongham mentioned this pull request Oct 7, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 7, 2022
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@bonachylauriel bonachylauriel mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Feb 14, 2023
Open
@B020239 B020239 mentioned this pull request Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin389 martin389 martin389 approved these changes

Assignees

@martin389 martin389

Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include work around for wildcards in HTTP Proxy Exclusion list on GHES
4 participants
@mzzmjd @janiceilene @brntbeer @martin389