Skip to content

Add security overview to github-security-features.md #15078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2022
Merged

Add security overview to github-security-features.md #15078

merged 4 commits into from
Feb 8, 2022

Conversation

lucie-docs
Copy link
Contributor

@lucie-docs lucie-docs commented Feb 4, 2022 •
edited
Loading

Why:

Closes https://github.com/github/docs-content/issues/6198

What's being changed:

Added the security overview to the "Available with GitHub Advanced Security" section for GHEC and GHES 3.2 and above.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/code-security/getting-started/github-security-features.md Modified Original

@github-actions github-actions bot temporarily deployed to docs-15078--update-github-secu February 4, 2022 15:57 Inactive
@github-actions github-actions bot temporarily deployed to docs-15078--update-github-secu February 4, 2022 16:08 Inactive
@lucie-docs
Copy link
Contributor Author

I'm not sure how to solve the check not passing, I did confirm that the issue linked in the PR is fine to have there 😞

@lucie-docs
Copy link
Contributor Author

Never mind, posting the previous comment solved the check haha

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team code security Content related to code security waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 4, 2022
@ramyaparimi
Copy link
Contributor

@lucie-docs
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@mchammer01 mchammer01 self-requested a review February 8, 2022 09:31
mchammer01
mchammer01 previously approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨ - thanks for adding this omission @lucie-docs

mchammer01
mchammer01 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mchammer01 mchammer01 enabled auto-merge February 8, 2022 09:42
@github-actions github-actions bot temporarily deployed to docs-15078--update-github-secu February 8, 2022 09:42 Inactive
@github-actions github-actions bot temporarily deployed to docs-15078--update-github-secu February 8, 2022 09:49 Inactive
@mchammer01 mchammer01 merged commit 85c963a into github:main Feb 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@lucie-docs lucie-docs deleted the update-github-security-features branch February 8, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees
No one assigned
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucie-docs @ramyaparimi @mchammer01