Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #1516

Merged
merged 3 commits into from
Dec 2, 2020
Merged

fix typo #1516

merged 3 commits into from
Dec 2, 2020

Conversation

wonda-tea-coffee
Copy link
Contributor

@wonda-tea-coffee wonda-tea-coffee commented Nov 21, 2020

Why:

because the package name was incorrect.

What's being changed:

loadash→lodash

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Nov 21, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@wonda-tea-coffee
Copy link
Contributor Author

@janiceilene
Sorry, corrected 👍

@janiceilene
Copy link
Contributor

Thanks so much @wonda-tea-coffee! I'll get this triaged for review 🌟

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team DSP labels Nov 24, 2020
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot.
Many thanks @wonda-tea-coffee for correcting this. 👍

@hubwriter hubwriter merged commit 50e8da1 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Octomerger added a commit that referenced this pull request Dec 2, 2020
* Improve documentation issue no #1034

Done with the minor fixes for open issue number #1034 .

* Increasing the importance

I wanted to delete a branch, but I couldn't in spite of reading this document. The problem was, the branch I wanted to delete was the default branch. 
Even though it is stated in this document, it was not given enough importance that everyone would see it.

* typo

A small type in the comments

* Update setting-up-your-development-environment-to-create-a-github-app.md

Fix two small typos.

* properly capitalize "macOS"

* Clarify GH password requirements

* Change " to `

As done in the description of `master`

* " to ` in DE

* " to ` in PT

* " to ` in RU

* Fix typo metadata-syntax-for-github-actions.md

Fix typo for metadata-syntax-for-github-actions#outputs-for-composite-run-steps-actions

* chore: Remove bolding from headings

* Removed deprecated echo set-env instruction

* fix typo (#1516)

Co-authored-by: hubwriter <hubwriter@github.com>

* Remove extraneous grammar period which breaks the compare URL (#1252)

* Remove extraneous grammar period which breaks the compare URL

* Update data/reusables/repositories/two-dot-diff-comparison-example-urls.md

Co-authored-by: Nick Schonning <nschonni@gmail.com>

Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: hubwriter <hubwriter@github.com>

* Revert "" to ` in RU"

This reverts commit d484fd6.

* Revert "" to ` in PT"

This reverts commit fab62f0.

* Revert "" to ` in DE"

This reverts commit 78abcd6.

* Change md

This squashes all the translation commits and their deletion.

* Update content/github/collaborating-with-issues-and-pull-requests/creating-and-deleting-branches-within-your-repository.md

Co-authored-by: Felicity Chapman <felicitymay@github.com>

Co-authored-by: Atharva Shirdhankar <72031540+StarTrooper08@users.noreply.github.com>
Co-authored-by: Aakarsh B <aakarshbiju@gmail.com>
Co-authored-by: Aritra Roy Gosthipaty <aritra.born2fly@gmail.com>
Co-authored-by: Guilherme Macedo <guilherme@gmacedo.com>
Co-authored-by: Stephen Wade <stephen@stephenwade.me>
Co-authored-by: Shao Yang Hong <hongsy2006@gmail.com>
Co-authored-by: a2br <62328077+a2br@users.noreply.github.com>
Co-authored-by: Cas van Dinter <casvd@hotmail.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Antoine Rondelet <rondelet.antoine@gmail.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Meg Bird <megbird@github.com>
Co-authored-by: ねず <39144575+wonda-tea-coffee@users.noreply.github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: Ilia <ilia@wearebond.com>
Co-authored-by: a2br <a2br@users.noreply.github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants