Skip to content

Pricing calculator new urls #15973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 10, 2022
Merged

Pricing calculator new urls #15973

merged 14 commits into from
Mar 10, 2022

Conversation

juniorjp
Copy link
Contributor

@juniorjp juniorjp commented Mar 1, 2022

Why:

Closes https://github.com/github/octogrowth/issues/188

What's being changed:

Updates the URL of pricing calculator to automatically open the related part:

Screen.Recording.2022-03-01.at.17.24.43.mov

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Mar 1, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/billing/managing-billing-for-github-actions/about-billing-for-github-actions.md Modified Original
content/billing/managing-billing-for-github-codespaces/about-billing-for-codespaces.md Modified Original
content/billing/managing-billing-for-github-packages/about-billing-for-github-packages.md Modified Original

@juniorjp juniorjp marked this pull request as ready for review March 1, 2022 20:38
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review billing Content related to billing and removed triage Do not begin working on this issue until triaged by the team labels Mar 2, 2022
@ramyaparimi
Copy link
Contributor

@juniorjp
Thanks so much for opening a PR! I'll get this triaged for review ⚡

lecoursen
lecoursen reviewed Mar 2, 2022
View reviewed changes
data/reusables/dotcom_billing/pricing_calculator/base_text.md Outdated
@@ -0,0 +1 @@
To estimate the costs for consumptive services, you can use the {% data variables.product.prodname_dotcom %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 @juniorjp, thanks so much for doing this work! We can't use partial sentences in reusables, because it makes localization (which is done for each reusable individually), impossible (reference). I noticed that each of the pricing_cal_X reusables are only used once, so I think it would be fine to just duplicate this base text, and put unique sentences in each article. I would offer to do that myself but I don't have access to your fork. Do you mind making that change, and then pinging me for another review? 🙏🏻 Thanks!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lecoursen ! Thank you for the review and valuable information! I just pushed the fix, but not sure if it's as expected, I would appreciate if you can review again when you have some time, thanks 💯 ! 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I just think we now need to delete this file since it's no longer used. 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, my bad I forgot to commit, thanks for catching that! 🥇 🚀

@lecoursen lecoursen enabled auto-merge March 7, 2022 16:00
@lecoursen lecoursen added the ready to merge This pull request is ready to merge label Mar 7, 2022
@lecoursen lecoursen removed the waiting for review Issue/PR is waiting for a writer's review label Mar 10, 2022
@lecoursen
Copy link
Member

@ramyaparimi, I'm not sure why this test is failing... could you work with engineering to figure that out as part of getting this merged? 🙏🏻

ramyaparimi
ramyaparimi approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving to merge

@lecoursen lecoursen merged commit 94005b7 into github:main Mar 10, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@ramyaparimi
Copy link
Contributor

@lecoursen Engineering team is looking into a fix for this. Until then re-running the jobs would do the trick. I am re-running the jobs on PRs with ready to merge label everyday until there is a fix 😅

@lecoursen
Copy link
Member

Until then re-running the jobs would do the trick.

Hmmm I actually tried that several times. Glad to hear it's working now!!

@juniorjp
Copy link
Contributor Author

Thank you so much for the help @lecoursen and @ramyaparimi! 🎉 🚀

@Kmbstreetz

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen left review comments

+1 more reviewer

@ramyaparimi ramyaparimi ramyaparimi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
billing Content related to billing content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juniorjp @ramyaparimi @lecoursen @Kmbstreetz @MohameddaahirD