Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify product tier requirement #15991

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Clarify product tier requirement #15991

merged 3 commits into from
Mar 8, 2022

Conversation

asmitbm
Copy link
Contributor

@asmitbm asmitbm commented Mar 2, 2022

Why:

Clarified product tier requirement in 'Managing code review settings for your team > About Auto Assignment'.
There's no difference between Team and Cloud on those collaboration features, as you can see at https://github.com/pricing.

Closes: #14851

What's being changed:

A para from the About auto assignment have been removed, as collaboration features mentioned there was part of both GitHub Team and GitHub Enterprise Cloud account.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@asmitbm
Clarify product tier requirement
40163bc 
Clarify product tier requirement in 'Managing code review settings for your team > About Auto Assignment'.
There's no difference between Team and Cloud on those collaboration features, as you can see at https://github.com/pricing.
@welcome
Copy link

welcome bot commented Mar 2, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 3, 2022
@ramyaparimi
Copy link
Contributor

@asmit2952
Thanks so much for opening a PR! I'll get this triaged for review ⚡

prensjr
prensjr reviewed Mar 3, 2022
View reviewed changes
Copy link

@prensjr prensjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good thanks

...t/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team.md Show resolved Hide resolved
felicitymay
felicitymay approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmit2952 - thank you for updating this article to reflect a change to the product tiers 💖

This looks great and we'll get this merged.

@felicitymay felicitymay added the ready to merge This pull request is ready to merge label Mar 8, 2022
@felicitymay felicitymay enabled auto-merge (squash) March 8, 2022 09:46
@felicitymay felicitymay removed the waiting for review Issue/PR is waiting for a writer's review label Mar 8, 2022
@felicitymay felicitymay merged commit 9c85909 into github:main Mar 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@MarcelRaschke MarcelRaschke mentioned this pull request Aug 20, 2022
Open
@RiyadhAsaameai RiyadhAsaameai mentioned this pull request Aug 29, 2022
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Nov 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prensjr prensjr prensjr left review comments

@felicitymay felicitymay felicitymay approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify product tier requirement in 'Managing code review settings for your team > About Auto Assignment'
4 participants
@asmitbm @ramyaparimi @felicitymay @prensjr