Skip to content

some grammeritical changes #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

some grammeritical changes #1689

wants to merge 2 commits into from

Conversation

ravikr126
Copy link

@ravikr126 ravikr126 commented Nov 29, 2020

Why:

What's being changed:

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Nov 29, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

…t/publicizing-or-hiding-organization-membership.md

Co-authored-by: Ed L <beartechtalks@gmail.com>
@ravikr126
Copy link
Author

Grammatical changes

Copy link
Contributor

@SMAKSS SMAKSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the PR. I think your changes are still subjective and there is no improvement whatsoever.

@Rexogamer
Copy link

Hi there, thanks for the PR. I think your changes are still subjective and there is no improvement whatsoever.

Whilst this likely isn't your intention, that second sentence comes off as a little bit rude :/

@ravikr126
Copy link
Author

Hi there, thanks for the PR. I think your changes are still subjective and there is no improvement whatsoever.

Whilst this likely isn't your intention, that second sentence comes off as a little bit rude :/

How I make contribution in open source ??
Please help me

@SMAKSS

This comment was marked as spam.

@SMAKSS

This comment was marked as spam.

@ravikr126
Copy link
Author

Thanks brother😊

@janiceilene
Copy link
Contributor

@ravikr126 Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

I agree that these changes are subjective, but if there's a reason you'd like to see those changes, we can consider them. By filling out the pull request template, the team can better understand the goal of your changes when we review your PR 💖

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 9, 2020
@janiceilene
Copy link
Contributor

janiceilene commented Dec 9, 2020

@ravikr126 Could you please fill out the pull request template in the top comment in this pull request, if you'd like this change to be considered?

Copy link
Author

@ravikr126 ravikr126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammatical enhancement

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Dec 10, 2020
@janiceilene
Copy link
Contributor

@ravikr126 Could you answer the Why: and What's being changed: in the top comment to help us understand the reason you feel these changes should be made? Especially since this change is subjective, it's helpful to know your thoughts behind the change so we can decide whether or not to merge it into the docs.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale There is no recent activity on this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants