Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix #1699

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Typo fix #1699

merged 2 commits into from
Dec 16, 2020

Conversation

pcowgill
Copy link
Contributor

Why:

Incorrect instructions when using setup-node action with a private repo

What's being changed:

Name of setup-node env var

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Nov 30, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 1, 2020
@janiceilene
Copy link
Contributor

@pcowgill Thanks so much for opening a PR! I'll get this triaged for review

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 9, 2020
@pcowgill
Copy link
Contributor Author

pcowgill commented Dec 9, 2020

@janiceilene Commenting so this isn't marked as stale. Thanks!

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 9, 2020
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix, @pcowgill! I'll get this merged in 🚀

@lucascosti lucascosti self-assigned this Dec 16, 2020
@lucascosti lucascosti merged commit 8b912a5 into github:main Dec 16, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants