Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks for managing disruptive comments #17280

Merged
merged 4 commits into from
May 11, 2022
Merged

Tweaks for managing disruptive comments #17280

merged 4 commits into from
May 11, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 21, 2022 •
edited
Loading

Why:

Closes #16446

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
communities/moderating-comments-and-conversations/managing-disruptive-comments.md fpt
ghes@ 3.4 3.3 3.2 3.1
ghae
ghec
 fpt
ghes@ 3.4 3.3 3.2 3.1
ghae
ghec

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review communities Content related to Communities get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Apr 22, 2022
@ramyaparimi
Copy link
Contributor

@jsoref
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@hubwriter
Copy link
Contributor

I've reached out to our Communities folks for a review of this.

robertnopickle
robertnopickle approved these changes May 9, 2022
View reviewed changes
Copy link

@robertnopickle robertnopickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense to me ❤️ 👍🏻 👍🏻

@ramyaparimi ramyaparimi added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels May 9, 2022
@hubwriter
Copy link
Contributor

@jsoref - Many thanks for making this improvement to the docs.

I'll get this merged/published now.
🚀

@hubwriter hubwriter enabled auto-merge (squash) May 10, 2022 11:26
@hubwriter hubwriter merged commit 04455e2 into github:main May 11, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@jsoref jsoref deleted the disruptive-comment-tweaks branch May 11, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnopickle robertnopickle robertnopickle approved these changes

@hubwriter hubwriter hubwriter approved these changes

Assignees
No one assigned
Labels
communities Content related to Communities content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Managing disruptive comments is overly prescriptive
4 participants
@jsoref @ramyaparimi @hubwriter @robertnopickle