-
Notifications
You must be signed in to change notification settings - Fork 60.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update applying-labels-to-issues-and-pull-requests.md #179
Conversation
This fix solves issue github#161 : Tip is update to reflect the max labels limit, and the previous text in this field was added to the bottom of the page as a complement to item 4.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @casals!
This looks good to me, but I'll defer to @github/docs-content for an authoritative review.
The staging deployment worked, but for some reason the check is hanging. Here's the staging URL with the changed page: http://docs-179--patch-1.herokuapp.com/en/free-pro-team@latest/github/managing-your-work-on-github/applying-labels-to-issues-and-pull-requests I will investigate the staging issue but in the meantime, this can be merged as all the other checks are passing. 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@casals Thank you so much for your contribution 🎉 🙌 Just a few small things to note before you merge 😄
content/github/managing-your-work-on-github/applying-labels-to-issues-and-pull-requests.md
Outdated
Show resolved
Hide resolved
content/github/managing-your-work-on-github/applying-labels-to-issues-and-pull-requests.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you push those edits I've suggested, I'll review it again and we can publish this one 👍 🎉
content/github/managing-your-work-on-github/applying-labels-to-issues-and-pull-requests.md
Outdated
Show resolved
Hide resolved
content/github/managing-your-work-on-github/applying-labels-to-issues-and-pull-requests.md
Outdated
Show resolved
Hide resolved
As per requested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! thank you very much for working on this with me 💛 merging as soon as tests are 🍏 🍏 🍏
Why:
Fixes #161 .
What's being changed:
Tip section updated to reflect the max labels limit, and the previous text in this field was added to the bottom of the page as a complement to item 4.
Check off the following: