Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update applying-labels-to-issues-and-pull-requests.md #179

Merged
merged 5 commits into from
Oct 8, 2020

Conversation

casals
Copy link
Contributor

@casals casals commented Oct 7, 2020

Why:

Fixes #161 .

What's being changed:

Tip section updated to reflect the max labels limit, and the previous text in this field was added to the bottom of the page as a complement to item 4.

Check off the following:

This fix solves issue github#161 : Tip is update to reflect the max labels limit, and the previous text in this field was added to the bottom of the page as a complement to item 4.
@welcome
Copy link

welcome bot commented Oct 7, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 7, 2020
Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @casals!

This looks good to me, but I'll defer to @github/docs-content for an authoritative review.

@zeke zeke requested a review from a team October 7, 2020 18:58
@zeke
Copy link
Contributor

zeke commented Oct 7, 2020

The staging deployment worked, but for some reason the check is hanging.

Here's the staging URL with the changed page: http://docs-179--patch-1.herokuapp.com/en/free-pro-team@latest/github/managing-your-work-on-github/applying-labels-to-issues-and-pull-requests

I will investigate the staging issue but in the meantime, this can be merged as all the other checks are passing. 👍🏼

Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casals Thank you so much for your contribution 🎉 🙌 Just a few small things to note before you merge 😄

Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you push those edits I've suggested, I'll review it again and we can publish this one 👍 🎉

Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! thank you very much for working on this with me 💛 merging as soon as tests are 🍏 🍏 🍏

@megbird megbird merged commit e63e172 into github:main Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Article should note limit of 100 labels applied to issues and pull requests
4 participants