Skip to content

Fix electron docs page not found. #22295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix electron docs page not found. #22295

wants to merge 1 commit into from

Conversation

meel-hd
Copy link

@meel-hd meel-hd commented Nov 26, 2022

Why:

When visiting Electron docs the url from Github docs takes you to https://electronjs.org/docs/ which is not a valid url. The valid url is https://electronjs.org/docs/latest

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

When visiting Electron docs the url from Github docs  takes you to https://electronjs.org/docs/ which is not a valid url. The valid url is https://electronjs.org/docs/latest
@welcome
Copy link

welcome bot commented Nov 26, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 26, 2022
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

Copy link

@Mgace54201 Mgace54201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/rendering/sidebar.js

@cmwilson21
Copy link
Contributor

@meel-hd Thanks for submitting a PR with this fix! ✨

It looks like this link was updated in a recent PR merged today. So I'm going to go ahead and close this one.

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 closed this Nov 28, 2022
@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Nov 28, 2022
@meel-hd meel-hd deleted the patch-1 branch December 1, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants