Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect example link on Searching Commits #2319

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Fix incorrect example link on Searching Commits #2319

merged 3 commits into from
Jan 7, 2021

Conversation

gustavobini
Copy link
Contributor

@gustavobini gustavobini commented Dec 24, 2020 •
edited
Loading

Why:

#2318

What's being changed:

The example that says committer-date:>2016-01-01 matches commits committed after 2016-01-01. is having its URL match the description.

Check off the following:

@welcome
Copy link

welcome bot commented Dec 24, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene linked an issue Dec 28, 2020 that may be closed by this pull request
Incorrect example link in "Searching Commits" #2318
Closed
@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Dec 28, 2020
hubwriter
hubwriter approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobini - Many thanks for implementing this fix. 👍

@hubwriter hubwriter self-assigned this Jan 7, 2021
@hubwriter hubwriter merged commit d62e288 into github:main Jan 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@gustavobini gustavobini deleted the patch-1 branch February 8, 2021 15:11
@colorado392 colorado392 mentioned this pull request Aug 20, 2023
Merged
@kavirmusic kavirmusic mentioned this pull request Sep 4, 2023
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Sep 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubwriter hubwriter hubwriter approved these changes

Assignees

@hubwriter hubwriter

Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect example link in "Searching Commits"
3 participants
@gustavobini @janiceilene @hubwriter