Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify inactive status made to same environment name #2430

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Clarify inactive status made to same environment name #2430

merged 3 commits into from
Feb 3, 2021

Conversation

bradymholt
Copy link
Contributor

@bradymholt bradymholt commented Dec 29, 2020 •
edited
Loading

Previous deployments to the same environment name will automatically be marked inactive so this update makes that clearer. Previously, the docs said all deployments in the same repository would be marked inactive.

Ref: https://developer.github.com/changes/2016-04-06-deployment-and-deployment-status-enhancements/#automatic-creation-of-inactive-statuses

Why:

Per #2429, the previous documentation needed clarification.

What's being changed:

The Inactive deployments section of the REST Reference docs.

image

Check off the following:

Fixes #2429

@bradymholt
Clarify inactive status made to same environment
dc05874 
Previous deployments to the same environment (name) will automatically be marked inactive so this update makes that clearer.  Previously, the doc said all deployments
in the same respository.

Ref: https://developer.github.com/changes/2016-04-06-deployment-and-deployment-status-enhancements/#automatic-creation-of-inactive-statuses
@welcome
Copy link

welcome bot commented Dec 29, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@bradymholt bradymholt changed the title Clarify inactive status made to same environment Clarify inactive status made to same environment name Dec 29, 2020
@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Jan 4, 2021
@janiceilene
Copy link
Contributor

Thanks so much for opening a PR! I'll get this triaged for review ✨

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 11, 2021
@bradymholt
Copy link
Contributor Author

@janiceilene - Do I need to do anything here to prevent this PR from getting closed?

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 11, 2021
@janiceilene
Copy link
Contributor

Nothing you need to do @bradymholt 💛 Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 19, 2021
@skedwards88 skedwards88 removed the stale There is no recent activity on this issue or pull request label Jan 19, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 27, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 28, 2021
@skedwards88 skedwards88 self-assigned this Feb 3, 2021
skedwards88
skedwards88 reviewed Feb 3, 2021
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you for adding this clarification! I made one small optional wording suggestion. Let me know what you think, then I'll get this merged down for you.

content/rest/reference/repos.md Outdated Show resolved Hide resolved
@bradymholt @skedwards88
Update content/rest/reference/repos.md
c7a01f1 
Co-authored-by: Sarah Edwards <skedwards88@github.com>
skedwards88
skedwards88 approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM! I'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Feb 3, 2021
@skedwards88 skedwards88 merged commit 31e555d into github:main Feb 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Dmarch28 pushed a commit to Dmarch28/docs that referenced this pull request Mar 4, 2021
@bradymholt @Dmarch28
Clarify inactive status made to same environment name (github#2430)
7e5a61f
Dmarch28 pushed a commit to Provider-of-Algorithms/docs that referenced this pull request Mar 7, 2021
@bradymholt @Dmarch28
Clarify inactive status made to same environment name (github#2430)
d9955ab
@SerchVet SerchVet mentioned this pull request Jun 28, 2023
Open
@vivandiu vivandiu mentioned this pull request Jul 14, 2023
Open
@Theo13111 Theo13111 mentioned this pull request Aug 3, 2023
Open
@Ka11ex420x Ka11ex420x mentioned this pull request Aug 11, 2023
Open
@colorado392 colorado392 mentioned this pull request Aug 12, 2023
Merged
@Woodpile37 Woodpile37 mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees

@skedwards88 skedwards88

Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify automatic creation of inactive statuses is for same environment
3 participants
@bradymholt @janiceilene @skedwards88