Skip to content

- documents the lack of CORS pre-flight support #25563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2023
Merged

- documents the lack of CORS pre-flight support #25563

merged 2 commits into from
May 16, 2023

Conversation

baywet
Copy link
Contributor

@baywet baywet commented May 15, 2023

partial
Closes #22270

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@baywet Thanks so much for opening a PR! I've edited your post to link your PR to your issue.

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team labels May 16, 2023
@azazirasheed

This comment was marked as spam.

Copy link
Contributor

@jhosman jhosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR with this fix! I'll update the branch, and we'll get this merged once tests are passing.

@jhosman jhosman enabled auto-merge May 16, 2023 22:48
@jhosman jhosman added this pull request to the merge queue May 16, 2023
Merged via the queue into github:main with commit 54ffa2b May 16, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Authorizing OAuth Apps doesn't mention the access_token endpoint doesn't support CORS
4 participants